Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the asyncCommit and queueToRetryCommit always failed in db mode #5604

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented May 24, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

In the db mode, the GlobalSession.asyncCommit and GlobalSession.queueToRetryCommit always failed.
在DB模式下,GlobalSession.asyncCommitGlobalSession.queueToRetryCommit 两个方法总是失败。

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

  1. 复现 asyncCommit 报错:一个全局事务可以异步全局提交,就会碰到该问题。比如:全部是AT分支。
  2. 复现 queueToRetryCommit 报错:可以在分支提交时,设置断点,故意把RM关掉,让一个分支提交失败,让全局事务进入异步重试提交。

Ⅴ. Special notes for reviews

@Bughue
Copy link
Contributor

Bughue commented May 24, 2023

是漏删了,我重新梳理了一下,放到这里吧,以后如果set status要改动的话可以再回来看看这个pr

image

我的pr也关联一下吧 #4858

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM changelog 补充下

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/server server module labels May 24, 2023
@funky-eyes funky-eyes added this to the 2.0.0 milestone May 24, 2023
@funky-eyes funky-eyes merged commit 8f9bba2 into apache:2.x May 25, 2023
6 of 7 checks passed
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The impact of file, DB, and Redis storage modes has been evaluated.

Pil0tXia pushed a commit to Pil0tXia/seata that referenced this pull request Jun 14, 2023
my change 2

optimize: optimize channel availability thread log output (apache#5563)

feature:docker image supports JVM parameter injection (apache#5529)

test: add unit test for transaction messages (apache#5637)

feature: support trace the transaction link according to the XID (apache#5600)

test: add unit test case for ExporterType/RegistryType (apache#5622)

optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623)

optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623)

optimize: support case-sensitive attributes for table and column metadata (apache#5553) (+14 squashed commit)

Squashed commit:

[c97f409] mychange 1

my change 2

optimize: optimize channel availability thread log output (apache#5563)

feature:docker image supports JVM parameter injection (apache#5529)

test: add unit test for transaction messages (apache#5637)

feature: support trace the transaction link according to the XID (apache#5600)

test: add unit test case for ExporterType/RegistryType (apache#5622)

[8f9bba2] bugfix: fix the `asyncCommit` and `queueToRetryCommit` always failed in db mode (apache#5604)

[b2d4584] bugfix: fix log in participant transaction role (apache#5594)

[d0d012c] feature: support sqlserver in AT mode (apache#3887)

[54bd3ca] feature:support MS SqlServer on the server side of AT mode (apache#4033)

[d1e6e6b] bugfix: grpc interceptor xid unbinding problem (apache#5577)

[0b49e06] optimize: The common fence clean task is only initiated when useTCCFence is set to true (apache#5576)

[7e40e05] bugfix: fix mariadb rollback failed (apache#5558)

[ee1ecf7] bugfix: fix oracle insert undolog failed (apache#5556)

Signed-off-by: slievrly <slievrly@163.com>

[0a1edf3] optimize: update expire gpg key and publish workflow (apache#5549)

Signed-off-by: slievrly <slievrly@163.com>

[1c8e4bf] bugfix: the log file path was loaded incorrectly (apache#5531)

[c73d72d] bugfix: fix GlobalStatus=9 can't be cleared in DB storage mode (apache#5523)

[83493d9] optimize: optimize FenceHandler for oracle (apache#5519)

[9b35ba9] bugfix: fix the full table scan issue with 'setDate' condition in Oracle 10g (apache#5498)
@wangliang181230 wangliang181230 deleted the bugfix-asyncCommit-queueToRetryCommit-failed branch June 14, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants