optimize: support case-sensitive attributes for table and column metadata #5647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data Signed-off-by: slievrly <slievrly@163.com>
funky-eyes
reviewed
Jun 14, 2023
| @@ -106,6 +106,9 @@ private TableMeta resultSetMetaToSchema(ResultSetMetaData rsmd, DatabaseMetaData | |||
|
|
|||
| TableMeta tm = new TableMeta(); | |||
| tm.setTableName(tableName); | |||
| //always true and nothing to do with escape characters for mysql. | |||
| // May be not consistent with lower_case_table_names | |||
| tm.setCaseSensitive(true); | |||
There was a problem hiding this comment.
Why not use SHOW VARIABLES LIKE 'lower_case_table_names'. 其他几个db同理
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
support case-sensitive attributes for table and column metadata
Ⅱ. Does this pull request fix one issue?
fix #5553
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews