Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix escaped characters for upper and lower case column names #5658

Merged
merged 7 commits into from Jun 27, 2023

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Jun 17, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

image
image

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: OracleEscapeHandler#checkIfNeedEscape 、 PostgresqlEscapeHandler#checkIfNeedEscape

@slievrly slievrly changed the title bugfix: the issue of case sensitivity enforcement on the database after adding escape characters to keywords bugfix: fix escaped characters for upper and lower case column names Jun 27, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 18d8905 into apache:2.x Jun 27, 2023
5 of 6 checks passed
@slievrly slievrly added this to the 2.0.0 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants