Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the timeout is null when the connectionProxyXA connection is reused #5661

Merged
merged 6 commits into from Jun 20, 2023

Conversation

PeppaO
Copy link
Contributor

@PeppaO PeppaO commented Jun 17, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Fixes #5621

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@PeppaO PeppaO closed this Jun 17, 2023
@PeppaO PeppaO reopened this Jun 17, 2023
@PeppaO
Copy link
Contributor Author

PeppaO commented Jun 17, 2023

update

@PeppaO PeppaO changed the title 修复connectionProxyXA连接复用,cleanXABranchContext重置timeout为null异常 bugfix: fix the timeout is null when the connectionProxyXA connection is reused Jun 17, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@PeppaO
Copy link
Contributor Author

PeppaO commented Jun 18, 2023

image
check pass

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.0.0 milestone Jun 20, 2023
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. mode: XA XA transaction mode module/rm-datasource rm-datasource module labels Jun 20, 2023
@funky-eyes funky-eyes merged commit 961126d into apache:2.x Jun 20, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: XA XA transaction mode module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
3 participants