bugfix: fix the key parameter problem of sofa-rpc setAttachment() method #5745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Jul 24, 2023
|
@a364176773 我看 |
slievrly
reviewed
Jul 25, 2023
| /** | ||
| * The constant HIDDEN_KEY_BRANCH_TYPE | ||
| */ | ||
| public static final String HIDDEN_KEY_BRANCH_TYPE = Constants.HIDE_KEY_PREFIX_CHAR + KEY_BRANCH_TYPE; |
slievrly
reviewed
Jul 25, 2023
| RpcInternalContext.getContext().setAttachment(RootContext.KEY_XID, xid); | ||
| RpcInternalContext.getContext().setAttachment(RootContext.KEY_BRANCH_TYPE, branchType.name()); | ||
| RpcInternalContext.getContext().setAttachment(RootContext.HIDDEN_KEY_XID, xid); | ||
| RpcInternalContext.getContext().setAttachment(RootContext.HIDDEN_KEY_BRANCH_TYPE, branchType.name()); |
There was a problem hiding this comment.
Here are some case to prove RpcInternalContext.getContext().setAttachment(RootContext.KEY_XID, xid); not as expected ?
@a364176773 已补充 |
|
develop 也需要同步一个pr |
funky-eyes
added
type: bug
OK，我同步一下 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
在
sofa-rpc中，RpcInternalContext.getContext().setAttachment()方法的key参数要求以.或者_开头，否则会抛异常Ⅱ. Does this pull request fix one issue?
fix #3835
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews