Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix XA transaction start exception and rollback failure #5810

Merged
merged 4 commits into from Aug 29, 2023

Conversation

capthua
Copy link
Contributor

@capthua capthua commented Aug 28, 2023

…d by druid dependency conflict

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

  1. 使用Seata的JdbcUtilsJdbcConstants分别获取dbType,判断dbType是否是特定的类型,避免druid依赖冲突导致的异常
  2. 补充数据库的类型

Ⅱ. Does this pull request fix one issue?

fixes #5775

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 补充下changelog

@funky-eyes funky-eyes added this to the 2.0.0 milestone Aug 29, 2023
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. mode: XA XA transaction mode module/core core module module/rm-datasource rm-datasource module module/sqlparser sql-parser module labels Aug 29, 2023
@capthua
Copy link
Contributor Author

capthua commented Aug 29, 2023

LGTM 补充下changelog

已补充

@slievrly slievrly changed the title bugfix: fix XA transaction start exception and rollback failure caused by druid dependency conflict bugfix: fix XA transaction start exception and rollback failure Aug 29, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit c394c17 into apache:2.x Aug 29, 2023
6 checks passed
@capthua capthua deleted the 2.x-xa-rollback-fail branch September 8, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: XA XA transaction mode module/core core module module/rm-datasource rm-datasource module module/sqlparser sql-parser module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xa start error retry rollback
3 participants