Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize log in ConnectionProxyXA #5885

Merged
merged 2 commits into from Sep 28, 2023
Merged

Conversation

capthua
Copy link
Contributor

@capthua capthua commented Sep 26, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

将ConnectionProxyXA中log的字符串拼接改为占位符的形式

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.0.0 milestone Sep 26, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #5885 (e7d9160) into 2.x (4c6d48e) will decrease coverage by 0.17%.
Report is 1 commits behind head on 2.x.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5885      +/-   ##
============================================
- Coverage     48.90%   48.74%   -0.17%     
+ Complexity     4464     4437      -27     
============================================
  Files           821      821              
  Lines         28641    28641              
  Branches       3571     3571              
============================================
- Hits          14007    13960      -47     
- Misses        13177    13224      +47     
  Partials       1457     1457              
Files Coverage Δ
...in/java/io/seata/server/session/BranchSession.java 79.45% <100.00%> (ø)
...a/io/seata/rm/datasource/xa/ConnectionProxyXA.java 56.49% <33.33%> (ø)

... and 17 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 67c9c46 into apache:2.x Sep 28, 2023
8 checks passed
@capthua capthua deleted the 2.x branch October 8, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants