Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: standardized the properties of codecov.yml #5918

Merged
merged 2 commits into from Oct 16, 2023

Conversation

l81893521
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

standardized the properties of codecov.yml

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #5918 (7bab56f) into develop (357f8e8) will increase coverage by 0.01%.
Report is 81 commits behind head on develop.
The diff coverage is 69.90%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5918      +/-   ##
=============================================
+ Coverage      48.79%   48.81%   +0.01%     
+ Complexity      4176     4167       -9     
=============================================
  Files            743      793      +50     
  Lines          26617    28003    +1386     
  Branches        3327     3417      +90     
=============================================
+ Hits           12989    13669     +680     
- Misses         12225    12911     +686     
- Partials        1403     1423      +20     
Files Coverage Δ
...c/main/java/io/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...ommon/src/main/java/io/seata/common/Constants.java 100.00% <ø> (ø)
.../src/main/java/io/seata/common/util/BlobUtils.java 60.00% <100.00%> (ø)
...n/src/main/java/io/seata/common/util/PageUtil.java 50.00% <ø> (ø)
...ava/io/seata/compressor/deflater/DeflaterUtil.java 80.64% <100.00%> (ø)
.../main/java/io/seata/config/ConfigurationCache.java 73.33% <100.00%> (-0.75%) ⬇️
...c/main/java/io/seata/core/context/RootContext.java 46.77% <ø> (ø)
...seata/core/exception/TransactionExceptionCode.java 100.00% <100.00%> (ø)
...o/seata/core/protocol/AbstractIdentifyRequest.java 78.57% <100.00%> (+8.57%) ⬆️
.../seata/core/protocol/AbstractIdentifyResponse.java 75.00% <100.00%> (-6.49%) ⬇️
... and 116 more

... and 72 files with indirect coverage changes

- ".mvn/.*"
- ".style/.*"
- "*.md"
- "**/test"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more upper folder?

Does this include the following cases?

server/test/xxx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this rule will ignore any folders and files that call test. The example: https://docs.codecov.com/docs/ignoring-paths#ignoring-specific-file-names

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 9dd2c18 into apache:develop Oct 16, 2023
8 checks passed
@wangliang181230 wangliang181230 added this to the 1.8.0 milestone Oct 26, 2023
@l81893521 l81893521 deleted the optimize_codecov branch November 7, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants