Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the issue of missing sentinel password in store redis mode #5931

Merged
merged 8 commits into from Oct 18, 2023

Conversation

PeppaO
Copy link
Contributor

@PeppaO PeppaO commented Oct 14, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

当store.redis.mode=sentinel时,设置哨兵密码时,代码中缺少哨兵密码

Ⅱ. Does this pull request fix one issue?

#4161

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeppaO check style failed.
image

@slievrly slievrly changed the title fix the problem of missing sentinel password in store redis mode bugfix: fix the issue of missing sentinel password in store redis mode Oct 16, 2023
@PeppaO
Copy link
Contributor Author

PeppaO commented Oct 17, 2023

@PeppaO check style failed. image

done

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #5931 (8cb7ff0) into develop (971d1de) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #5931   +/-   ##
==========================================
  Coverage      48.86%   48.86%           
- Complexity      4171     4172    +1     
==========================================
  Files            793      793           
  Lines          28003    28007    +4     
  Branches        3417     3417           
==========================================
+ Hits           13683    13685    +2     
+ Misses         12895    12894    -1     
- Partials        1425     1428    +3     
Files Coverage Δ
...c/main/java/io/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...seata/server/storage/redis/JedisPooledFactory.java 25.53% <0.00%> (-0.56%) ⬇️
.../properties/server/store/StoreRedisProperties.java 29.78% <0.00%> (-2.04%) ⬇️

... and 2 files with indirect coverage changes

@slievrly slievrly added this to the 1.8.0 milestone Oct 18, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants