Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix global transaction hook repeat execute #5997

Merged
merged 3 commits into from Nov 6, 2023

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Nov 6, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fixes #5595

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (2.x@af72c60). Click here to learn what that means.
The diff coverage is 52.63%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.x    #5997   +/-   ##
======================================
  Coverage       ?   49.24%           
  Complexity     ?     4728           
======================================
  Files          ?      911           
  Lines          ?    31305           
  Branches       ?     3772           
======================================
  Hits           ?    15416           
  Misses         ?    14358           
  Partials       ?     1531           
Files Coverage Δ
...in/java/io/seata/tm/api/TransactionalTemplate.java 55.05% <52.63%> (ø)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.0.0 milestone Nov 6, 2023
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/tm tm module labels Nov 6, 2023
@funky-eyes funky-eyes merged commit 967906b into apache:2.x Nov 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/tm tm module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeatedly executed hook in TransactionalTemplate
3 participants