test: fix saga async tests undefined behavior #6005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 7, 2023 16:52
…ds 30 seconds by enlarging timeout to 5 minutes
funky-eyes
reviewed
Nov 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6005 +/- ##
=========================================
Coverage 49.45% 49.46%
- Complexity 4749 4752 +3
=========================================
Files 911 911
Lines 31315 31315
Branches 3773 3773
=========================================
+ Hits 15487 15490 +3
Misses 14286 14286
+ Partials 1542 1539 -3 |
|
Hint message when lock timeout, see commit 237b3c3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
There has been an saga async test case error when running time exceeds 30 seconds. Try to increase the waiting time and see if the error would disappear.
And fix typo "waittingForFinish" to "waitingForFinish".
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews