Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse the same coordinator instance. resolve #924 #925

Merged
merged 5 commits into from Apr 29, 2019
Merged

Reuse the same coordinator instance. resolve #924 #925

merged 5 commits into from Apr 29, 2019

Conversation

kezhenxu94
Copy link
Member

Ⅰ. Describe what this PR did

Reuse the same coordinator instance

Ⅱ. Does this pull request fix one issue?

fixes #924

Ⅲ. Why don't you add test cases (unit test/integration test)?

did not change logic

Ⅳ. Describe how to verify it

CI passed

Ⅴ. Special notes for reviews

null

@codecov-io
Copy link

codecov-io commented Apr 27, 2019

Codecov Report

Merging #925 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #925      +/-   ##
=============================================
- Coverage      37.73%   37.73%   -0.01%     
  Complexity      1033     1033              
=============================================
  Files            224      224              
  Lines           8795     8793       -2     
  Branches        1063     1062       -1     
=============================================
- Hits            3319     3318       -1     
  Misses          5082     5082              
+ Partials         394      393       -1
Impacted Files Coverage Δ Complexity Δ
server/src/main/java/io/seata/server/Server.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...eata/core/rpc/netty/AbstractRpcRemotingClient.java 17.22% <0%> (-0.48%) 7% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b537ca9...bde4499. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.LGTM.

@xingfudeshi xingfudeshi merged commit bc39e6f into apache:develop Apr 29, 2019
nick-tan pushed a commit to nick-tan/seata that referenced this pull request Jul 12, 2019
@wangliang181230 wangliang181230 added this to the 0.5.* milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why do we need two coordinator objects
5 participants