Skip to content

Commit

Permalink
Turn off parallelism on stub and spec meta tests because they hit cla…
Browse files Browse the repository at this point in the history
…ss methods (globals)

[git-p4: depot-paths = "//src/minitest/dev/": change = 12127]
  • Loading branch information
zenspider committed Jun 15, 2019
1 parent 398e270 commit ab39d35
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/minitest/test_minitest_mock.rb
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ def test_mock_called_via_send_with_args
require "minitest/metametameta"

class TestMinitestStub < Minitest::Test
parallelize_me!
# Do not parallelize since we're calling stub on class methods

def setup
super
Expand Down
2 changes: 1 addition & 1 deletion test/minitest/test_minitest_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,7 @@ def test_it_wont_add_test_methods_to_children
end

class TestMeta < MetaMetaMetaTestCase
parallelize_me!
# do not call parallelize_me! here because specs use register_spec_type globally

def util_structure
y = z = nil
Expand Down

0 comments on commit ab39d35

Please sign in to comment.