Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose options #645

Closed

Conversation

alkalinecoffee
Copy link

@alkalinecoffee alkalinecoffee commented Sep 15, 2016

This PR exposes the minitest options var.

Our team leverages minitest with a custom library to make live HTTP requests against our APIs. Particularly, we want access to the generated seed value so we can easily identify specific test runs in logs/splunk (our API test library would pass this value along in each request during the test run).

@aiomaster
Copy link

LOL, just now I see this pull request that does very much the same like mine:
#657

Sorry @alkalinecoffee , that I had not seen this before.
It would be very cool if one of these two pull requests could get merged.

@zenspider: Should I close mine?
Only difference is, where exactly the options variable is set.

@zenspider
Copy link
Collaborator

I absolutely do NOT want options available to tests. Instead, I've exposed the seed being used via Minitest.seed.

@zenspider zenspider closed this Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants