Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many tests are failing with 3.20 (passed with 3.19 in same environment) #336

Closed
pravi opened this issue Apr 30, 2023 · 9 comments
Closed
Assignees

Comments

@pravi
Copy link

pravi commented Apr 30, 2023

Many tests fail like this,

 35) Failure:
TestRubyParserV32#test_if_pre_not__18 [/usr/lib/ruby/vendor_ruby/pt_testcase.rb:159]:
failed on input: "if not b then a end".
--- expected
+++ actual
@@ -1 +1,4 @@
-s(:if, s(:call, nil, :b), nil, s(:call, nil, :a))
+s(:if,
+ s(:call, s(:call, nil, :b).line(1), :!).line(1),
+ s(:call, nil, :a).line(1),
+ nil).line(1)

ruby version is 3.1

Full log here
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1035307

@pravi
Copy link
Author

pravi commented May 4, 2023

Following the steps mentioned in #337 and with rvm installed ruby 3.1, I can reproduce the same failure.

@pravi
Copy link
Author

pravi commented May 4, 2023

All tests pass with ruby 3.0 on debian bullseye, but fail on debian bookworm/sid with ruby 3.1

@pravi
Copy link
Author

pravi commented May 4, 2023

on debian bullseye also the tests fail with ruby 3.1.

@zenspider
Copy link
Member

zenspider commented May 13, 2023

The tests all pass for me with the following versions both on 3.20.0 and on head:

Passed: 2.7.8, 3.0.6, 3.1.4, 3.2.2
Failed: 

ETA: same with 3.19.2

@zenspider zenspider self-assigned this May 13, 2023
@zenspider
Copy link
Member

aaand same if I gh repo clone seattlerb/ruby_parser in /tmp/ and start from scratch with an empty gemset...

Sorry... but there's no reproduction steps here with which to get under debug. I can't do much otherwise.

It LOOKS like all your failures are of the __18 variant. If they're coming up looking like 2.0+ variants instead, then you're prolly not using the correct version of the parser somehow

@pravi
Copy link
Author

pravi commented May 21, 2023

@zenspider the tests are passing with ruby 3.1.4 but failing with ruby 3.1.2! I will ask ruby maintainers in debian to update it.

@zenspider
Copy link
Member

Nope:

10006 % ruby -vS rake
ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [arm64-darwin22]


Run options: --seed 33718

# Running:

...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S..................................................................................................S...........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S...........................................................................................S........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S...........................................................................................................................................................................................................................................................S..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S...............................................................................................................................................................................................................................................................S............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S.............................................................................................S................................................................................................................................................................................................................................................................S...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S..................................................................................................S.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S...............................................................................................................................................................................................................................................................S....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S.................................................................................................S.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S.................................................................................................S.............................................................................................................................................................................................................................................................................S........................................................................................................................................................................................................................................................................S......................................................................................................................................................................................................................................................................................................................................................................................................................................................

Finished in 1.328530s, 7926.0536 runs/s, 30099.4332 assertions/s.

10530 runs, 39988 assertions, 0 failures, 0 errors, 22 skips

You have skipped tests. Run with --verbose for details.

@zenspider zenspider closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2023
@pravi
Copy link
Author

pravi commented May 22, 2023

Ah, then it is some other gem in debian sid/bookworm causing this.

@pravi
Copy link
Author

pravi commented Jun 19, 2023

This was caused by sexp_processor 4.16.1, after updating it to 4.17.0, the tests are passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants