Party ID pool runs out of IDs over time

[alborrajo]

Describe the bug
There may be some unhandled case in which a party disbands without the server knowing. The ID pool runs out and no more players can join the game anymore.

To Reproduce
Run the server and have players join and leave over time. It took about 3 months for this issue to happen.

Expected behavior
IDs should return to the pool in all cases the party no longer exists.

[alborrajo]

None of the logs over these months have shown the "Failed to remove partyId" error message.

[alborrajo]

A workaround has been pushed with PR #177 that prevents this issue from requiring a server restart for new players to join

[pacampbell]

I attempted to address this in my recent quest PR. I found there was an issue which happened where a player was in one party and then was invited to another party. This would fail, then when the client asked to create a solo party for the player this would also fail because they were already invited to another party. The client would then panic and keep requesting to make a party over and over, causing the party IDs to get exhausted. This would happen until the player logs out.

I am not sure if there exists more issues like this, but this was probably at least one reason for this bug which is hopefully fixed now.