Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try catch fails if $value is '' #55

Closed
leecrosdale opened this issue Apr 12, 2019 · 1 comment
Closed

Try catch fails if $value is '' #55

leecrosdale opened this issue Apr 12, 2019 · 1 comment
Labels
bug

Comments

@leecrosdale
Copy link
Contributor

craft-linkfield/src/fields/LinkField.php

Line 118 in fe676cd

$attr += Json::decode($value, true);

fails if $value is '' with an 'Unsupported operand types' error.
@leecrosdale
Copy link
Contributor Author

I think this will fail any time that Json::decode returns null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastian-lenz @leecrosdale