Skip to content
This repository has been archived by the owner on Jul 26, 2021. It is now read-only.

Uneeded file in git #94

Closed
remicollet opened this issue May 6, 2020 · 2 comments
Closed

Uneeded file in git #94

remicollet opened this issue May 6, 2020 · 2 comments

Comments

@remicollet
Copy link

remicollet commented May 6, 2020

Thanks to c22d9fe we now have to use a git snapshot to be able to properly use this project.

Surprize, tarball is 200 time bigger (from 14K to 2.9M) :(

Looking, I don't see why the "tools" directory is tracked, this are only a copy of some upstream commands (composer, ...)

Please remove them (and .gitignore them)

@sebastianbergmann
Copy link
Owner

The tools directory is not under version control by accident: this is not a bug.

The changes made in c22d9fe (as well as with similar commits in (hopefully) all of my repositories recently) optimize for the common case: installing a tool or library using Composer. By default, Composer uses the archives that GitHub automatically creates based on tags. The changes made in c22d9fe makes these archives smaller, meaning users of the libraries and tools in question need to download less.

In contrast to the common use case described above is the less common use case of working on the tool or library in question. I am sorry that you have to deal with larger downloads now, but I will not remove the tools directory from version control in any of my repositories.

@remicollet
Copy link
Author

Things going more crazy everyday....
Shame on PHP world

BTW, this will also affects user of composer with --prefer-sources

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants