Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call url() in sessionPrepare() #217

Closed
alecpl opened this issue Jan 29, 2013 · 4 comments
Closed

Don't call url() in sessionPrepare() #217

alecpl opened this issue Jan 29, 2013 · 4 comments

Comments

@alecpl
Copy link

alecpl commented Jan 29, 2013

In PHPUnit_Extensions_Selenium2TestCase::prepareSession() we have $this->url(''); which makes that before every test the "root url" is called in the browser. It is very expensive operation here. What if we do $this->url((string)$this->getBrowserUrl()); instead? Or maybe we can get rid of this line at all? Works for me.

@zerkms
Copy link
Collaborator

zerkms commented Jan 30, 2013

++

It actually annoys me as well. I've even created a blank page for that: so the initial url is a blank page and then a particular test loads a particular url, right after the blank page is loaded.

@jaruzafa
Copy link

+1 to this issue. I've implemented the same solution zerkms has noted.

@giorgiosironi
Copy link
Owner

I cannot remember the reason why we do this, I will remove the call as soon as I have a machine where I can run the full suite and verify it's really not necessary.

@giorgiosironi
Copy link
Owner

Done, but will be a BC break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants