Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding two more libraries to "Extensions" page? #27

Closed
martin-helmich opened this issue Feb 9, 2018 · 6 comments
Closed

Adding two more libraries to "Extensions" page? #27

martin-helmich opened this issue Feb 9, 2018 · 6 comments

Comments

@martin-helmich
Copy link

Hello Sebastian,

I just noticed the "extensions" page on the PHPUnit website and was wondering if you'd be willing to accept pull requests to add a few more to that list. I'm asking since I've been sitting on a few PHPUnit extension libraries that I've been maintaining for a while now and I think might fit well into that list (more precisely, my phpunit-json-assert and phpunit-psr7-assert package).

Thoughts?

@keradus
Copy link

keradus commented Mar 28, 2018

I would disrecommend adding custom assertions to website. If we would go that way, one would end up proposing hundreds of those custom assertion package.
If you believe that your assertions are generic and worth spreading, why not simply raising a PR to add them to main repo? :)

@sebastianbergmann
Copy link
Owner

Because I do not want to bloat PHPUnit (anymore).

@martin-helmich
Copy link
Author

I would disrecommend adding custom assertions to website. If we would go that way, one would end up proposing hundreds of those custom assertion package.

@keradus Thanks for the feedback. If not promoting third-party extensions, what other purpose does the "extensions" page serve?

@sebastianbergmann
Copy link
Owner

@martin-helmich Can you send a pull request, please?

@martin-helmich
Copy link
Author

@sebastianbergmann 👍 Done

@sebastianbergmann
Copy link
Owner

I decided to remove the extensions page. I do not think (anymore) that such a list should be hosted on PHPUnit's website or that I should be the one curating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants