-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.2.5 breaks BC ! #3176
Comments
Why do people overwrite PHPUnit's assertions? sigh |
short story? because they are not marked as final long story? vide https://github.com/PHPUnitGoodPractices/Traits/blob/master/src/IdentityOverEqualityTrait.php#L46-L56 for my concrete case |
I shall make them |
Then, can we first bring from dead topic of registering assertions/expectations? So one can decide to have some extra assertions available globally (without manual import in every single test) or not register all built-in ones ? Also, let me request this once more ;) please, let us start using |
newly released 7.2.5 breaks BC:
bcb4c78#diff-9ae7a972d07df5f73629d5d315bf405aR521
formal declaration of method changed:
for that, my integration crashes on incompatible method headers:
https://travis-ci.org/FriendsOfPHP/PHP-CS-Fixer/jobs/394945074#L655
The text was updated successfully, but these errors were encountered: