Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare return types for InvocationStubber methods #3871

Closed
sebastianbergmann opened this issue Sep 19, 2019 · 0 comments
Closed

Declare return types for InvocationStubber methods #3871

sebastianbergmann opened this issue Sep 19, 2019 · 0 comments
Assignees
@sebastianbergmann
Labels
feature/test-doubles Stubs and Mock Objects type/backward-compatibility Something will be/is intentionally broken
Milestone
PHPUnit 10.0

Comments

@sebastianbergmann
Copy link
Owner

The methods of PHPUnit\Framework\MockObject\Builder\InvocationStubber currently have /*: self */; instead of a proper return type declaration because : self; requires PHP 7.4.

This can be fixed once support for PHP 7.3 has been dropped.
@sebastianbergmann sebastianbergmann added the type/backward-compatibility Something will be/is intentionally broken label Sep 19, 2019
@sebastianbergmann sebastianbergmann added this to the PHPUnit 10.0 milestone Sep 19, 2019
@sebastianbergmann sebastianbergmann self-assigned this Sep 19, 2019
@sebastianbergmann sebastianbergmann added the feature/test-doubles Stubs and Mock Objects label Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
feature/test-doubles Stubs and Mock Objects type/backward-compatibility Something will be/is intentionally broken
Projects
None yet
Milestone
PHPUnit 10.0
Development

No branches or pull requests
1 participant
@sebastianbergmann