phpunit.bat on 3.5.0RC1 doesn't work

[mbeccati]

When running phpunit.bat on a freshly installed 3.5.0RC1 I get an error like "Files not expected" (sorry if it's not the real error, my OS is not english). A bit of debugging showed that the path environment variable PHPBIN was had double "double quotes". I'm not a .bat expert but here's one that works for me:

if "%PHPBIN%" == "" set PHPBIN=C:\Program Files (x86)\PHP\php.exe
if not exist "%PHPBIN%" if "%PHP_PEAR_PHP_BIN%" neq "" goto USE_PEAR_PATH
GOTO RUN
:USE_PEAR_PATH
set PHPBIN=%PHP_PEAR_PHP_BIN%
:RUN
"%PHPBIN%" "C:\Program Files (x86)\php\phpunit" %*

[sebastianbergmann]

• Did you use the PEAR Installer to install PHPUnit?
• Did the PEAR Installer correctly expand the @php_bin@ and @bin_dir@ placeholders?

[mbeccati]

Yes, installed via Pear, and expansion worked correctly. I can't remember any similar issues with 3.4, but of course I can test that as well.

[mbeccati]

Basically the issue on my system is that the PHPBIN env var is not set. At the first run its content becomes "C:\Program Files (x86)\PHP\php.exe" and the following run will execute:

if ""C:\Program Files (x86)\PHP\php.exe"" == "" set ...

which apparently isn't properly formatted. The patch fixes the issue by making sure that the PHPBIN variable doesn't contain double quotes, while adding them at execution time.

I took some time to clone the git repo and prepare a patch, you'll find it below:

[root@aperol ~/compile/phpunit]# git diff origin/master master
diff --git a/dbunit.bat b/dbunit.bat
index 70da6b5..02a70f9 100644
--- a/dbunit.bat
+++ b/dbunit.bat
@@ -34,10 +34,10 @@ REM ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
 OF THE
 REM POSSIBILITY OF SUCH DAMAGE.
 REM

-if "%PHPBIN%" == "" set PHPBIN="@php_bin@"
+if "%PHPBIN%" == "" set PHPBIN=@php_bin@
 if not exist "%PHPBIN%" if "%PHP_PEAR_PHP_BIN%" neq "" goto USE_PEAR_PATH
 GOTO RUN
 :USE_PEAR_PATH
-set PHPBIN="%PHP_PEAR_PHP_BIN%"
+set PHPBIN=%PHP_PEAR_PHP_BIN%
 :RUN
-%PHPBIN% "@bin_dir@\dbunit" %*
+"%PHPBIN%" "@bin_dir@\dbunit" %*
diff --git a/phpunit.bat b/phpunit.bat
index bd70a3d..29208ec 100644
--- a/phpunit.bat
+++ b/phpunit.bat
@@ -34,10 +34,10 @@ REM ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
 OF THE
 REM POSSIBILITY OF SUCH DAMAGE.
 REM

-if "%PHPBIN%" == "" set PHPBIN="@php_bin@"
+if "%PHPBIN%" == "" set PHPBIN=@php_bin@
 if not exist "%PHPBIN%" if "%PHP_PEAR_PHP_BIN%" neq "" goto USE_PEAR_PATH
 GOTO RUN
 :USE_PEAR_PATH
-set PHPBIN="%PHP_PEAR_PHP_BIN%"
+set PHPBIN=%PHP_PEAR_PHP_BIN%
 :RUN
-%PHPBIN% "@bin_dir@\phpunit" %*
+"%PHPBIN%" "@bin_dir@\phpunit" %*

[sebastianbergmann]

Can you please for PHPUnit, apply your patch, commit it, push it, and send me a pull request? That way author information is not lost and you get credit for your fix. Thanks!

[sebastianbergmann]

Merged, thanks.