@depends for PHPUnit_Extensions_SeleniumTestCase #56

Closed
cebe opened this Issue Oct 28, 2010 · 6 comments

Projects

None yet

2 participants

@cebe
cebe commented Oct 28, 2010

I searched for a long time but could not find any solution. I tried to use the @depends parameter with SeleniumTestCase but it did not work.
Is it because this is not implemented in SeleniumTestCase or is there some special trick to get it work?
If it's not implemented, consider this issues as a feature-request :-)

cebe commented Nov 1, 2010

Thanks for quick reply and work on it.
Your commits did not fix the issue but are a part of the necessary changes.
I found out, that the only point where PHPUnit_Framework_TestCase::setDependencies() is called is in http://github.com/sebastianbergmann/phpunit/blob/3.5/PHPUnit/Framework/TestSuite.php#L829
but this function never gets called when using PHPUnit_Extensions_SeleniumTestCase. I don't know if I am right, but I guess you have to change something in PHPUnit_Extensions_SeleniumTestCase::suite() to set dependencies when adding the tests.

In the future please file bugs related to PHPUnit_Extensions_SeleniumTestCase here: http://github.com/sebastianbergmann/phpunit-selenium/issues

Will do :-)

cebe commented Nov 3, 2010

I modified the
PHPUnit_Extensions_SeleniumTestCase::suite() but I am not shure if this fixes all cases. It works for all my tests but there are so many possible cases to add tests to a suite and suites to suites and so on. Please take a look at my changes here:
cebe/phpunit-selenium@b2874e7
If this fixes the issue, feel free to merge.

cebe commented Nov 3, 2010

seems as if this is still not the whole fix.
In some cases the data from the test the other test depends on is not given to the dependend test...
I'll try to find out more about it later, but it might take some time. Projects priority on testing is not that high at the moment.

Please open a new ticket under the PHPUnit_Selenium project in case the problem still persists.

cebe commented Feb 4, 2011

I wonder if https://github.com/sebastianbergmann/phpunit/issues#issue/10 might fix this problem when you finished work on it. are you still working on that issue?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment