Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excludeCollections in mongodb #344

Closed
mdjaman opened this issue Aug 11, 2023 · 4 comments
Closed

excludeCollections in mongodb #344

mdjaman opened this issue Aug 11, 2023 · 4 comments
Assignees
Labels

Comments

@mdjaman
Copy link
Contributor

mdjaman commented Aug 11, 2023

Hello there is a little bug on excludeCollections mongodb executable dump.

image

$cmd->addOptionIfNotEmpty('--excludeCollection', $this->excludeCollections);

should be as described in documentation

image
...
if (count($this->excludeCollections)) {
    foreach ($this->excludeCollections as $col) {
        $cmd->addOption('--excludeCollection', $col, ' ');
    }
}
@sebastianfeldmann
Copy link
Owner

Fixed thanks to #345 by @mdjaman

@mdjaman
Copy link
Contributor Author

mdjaman commented Aug 12, 2023

Hello @sebastianfeldmann thanks for committing it. Would u publish to new tag (6.0.20)?

@sebastianfeldmann
Copy link
Owner

Done ;)

@mdjaman
Copy link
Contributor Author

mdjaman commented Aug 12, 2023

Sorry i missed the notification 🙏 . Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants