Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HasEventListener will always return false in IE 7 #3

Closed
zackpudil opened this issue Aug 20, 2012 · 1 comment
Closed

HasEventListener will always return false in IE 7 #3

zackpudil opened this issue Aug 20, 2012 · 1 comment

Comments

@zackpudil
Copy link

HasEventListener will always return true do to a IE 7 bug in the get_valid_types_first_letter method. The bug is due to IE 7's short coming of not being able to index strings like arrays. So this line:

var first_try = (/Object|(Ele|Docu)ment|Window/.exec(Object.prototype.toString.call(object)) || [""])[0][0],

needs to be this line:

var first_try = (/Object|(Ele|Docu)ment|Window/.exec(Object.prototype.toString.call(object)) || [""])[0].charAt(0),

If you wanna support IE 7.

@sebastien-p
Copy link
Owner

Thank you, 2.0.4 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants