Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jint-defined exceptions should all derive from a Jint-specific Exception class #676

Closed
gregory-seidman opened this issue Oct 21, 2019 · 1 comment · Fixed by #679
Closed

Jint-defined exceptions should all derive from a Jint-specific Exception class #676

gregory-seidman opened this issue Oct 21, 2019 · 1 comment · Fixed by #679

Comments

@gregory-seidman
Copy link

Consider having an (abstract) Exception subclass, e.g. JintException, that all other custom exceptions subclass. This makes it possible for client code to catch all exceptions Jint might throw, even as new features are added and exception granularity grows.
@lahma lahma mentioned this issue Oct 27, 2019
Merged
@gregory-seidman
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Share common base class for exceptions lahma/jint
1 participant
@gregory-seidman