Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpandoObject cannot be set in 3.0.0-beta-1778 #725

Closed
lekrus opened this issue Apr 18, 2020 · 2 comments · Fixed by #726
Closed

ExpandoObject cannot be set in 3.0.0-beta-1778 #725

lekrus opened this issue Apr 18, 2020 · 2 comments · Fixed by #726
Labels

Comments

@lekrus
Copy link

lekrus commented Apr 18, 2020

Below test works in 3.0.0-beta-1767

dynamic expando = new ExpandoObject();
expando.Name = "test";
engine.SetValue("expando", expando);
engine.Execute("expando.Name").GetCompletionValue().ToString().Should().Be("test");

but fails in 3.0.0-beta-1778 with
System.ArgumentException: collection is supposed to either have Count or Length property

the change is introduced in #721, probably it's better to add an exception for ExpandoObject not to treat it as IsArrayLike?

Thanks!

@lahma
Copy link
Collaborator

lahma commented Apr 18, 2020

Thanks for reporting, #726 should fix this.

@lahma lahma added the bug label Apr 18, 2020
@lekrus
Copy link
Author

lekrus commented Apr 20, 2020

thanks a lot for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants