Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor DaylightSaving bug #778

Closed
Ellested opened this issue Aug 21, 2020 · 1 comment · Fixed by #1442
Closed

Minor DaylightSaving bug #778

Ellested opened this issue Aug 21, 2020 · 1 comment · Fixed by #1442

Comments

@Ellested
Copy link

image
image

When timeInYear is negative, and date is minValue, the date math is out of range.

@lahma
Copy link
Collaborator

lahma commented Aug 21, 2020

As a side note, when I tested Jint against latest ECMA suite I found out that there's some trouble with really common dates like year -2000 that JS wants to comply with. So I think the underlying problem is a bit bigger, we shouldn't rely on .NET's DateTime being the internal representation of Date object, it cannot handle all the lovely features of JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants