Match each table to at most one config section #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- filter duplicate table entries out of table_names in get_tables_and_gsis() - use collections.OrderedDict to preserve the order of table configuration sections as we parse the config file - use ordereddict from PyPi if we are using python < 2.7
|
...thoughts? |
|
@memory Thanks for your contribution. I think this makes sense. The problem for me is that it's breaking backwards compatibility (as some users current configuration will behave diffrently when this PR is merged). My strategy for version numbers is that
This would thus be an update to |
|
That seems valid -- it would definitely potentially break existing configurations. I will hold my breath for v2.0.0. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In re: #250
configuration sections as we parse the config file