Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Model.update()): fix onUpdateError throwing empty object instead of error #153

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

mickdekkers
Copy link
Contributor

Before this PR, if e.g. (joi) validation failed for the data, the error thrown there was lost and instead an empty object {} was thrown (this is the default parameter for onTransactionError).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.485% when pulling f7e5a0e on mickdekkers:fix/model-update-error into cb7c8be on sebelga:master.

@sebelga
Copy link
Owner

sebelga commented Feb 28, 2019

Hello,
Thanks for spotting this and for the PR! 👍

@sebelga sebelga merged commit b1929c7 into sebelga:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants