fix: call execPostHooks on internalTransaction #161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when using an internalTransaction (the default behaviour when no transaction is given) for the
update
method thetransaction.execPostHooks
function is never called.I fixed this by adding a line to the
internalTransaction
check and appending errors toentity[ERR_HOOKS]
I initially tried to add a test but found it non-trivial to mock the
transaction
used in theupdate
method.