Excludefromindexes: update logic to add all properties of Array embedded entities #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperties of Array embedded The v4.2.0 of the Datastore client allows wildcard "*" to target all the properties of an embedded entity. The logic to define the Array of excludeFromIndexes has been updated to make use of it. fix #132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic to calculate the
excludeFromIndexesarray. For array values with embedded entities it nows exclude not only the array but all the child properties of possible embedded entity (thanks to the new wildcard "*" operator https://github.com/googleapis/nodejs-datastore/pull/451/files#diff-574d28f5b7489fd2b49cb90d47efdf82R180)fix #132