Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema.date): allow valid string Date in validation #210

Merged
merged 1 commit into from
Dec 8, 2019

Conversation

sebelga
Copy link
Owner

@sebelga sebelga commented Dec 8, 2019

This fixes a bug where providing a valid string date with Date() was throwing a validation error.
Now any valid string date will be converted to date object before saving the entity.

fix #206

This fixes a bug where providing a valid string date with Date() was throwing a validation error.
Now any valid string date will be converted to date object before saving the entity.

fix #206
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 98.314% when pulling c01e6c5 on fix/allow-date-toString into 94b74d8 on master.

@sebelga sebelga merged commit 268c22e into master Dec 8, 2019
@sebelga sebelga deleted the fix/allow-date-toString branch December 8, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't save entity with 'Date' validated property
2 participants