Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): add transaction parameter to findOne #259

Merged
merged 6 commits into from
May 17, 2023

Conversation

dmk1111
Copy link
Contributor

@dmk1111 dmk1111 commented Nov 22, 2021

This adds Transaction support to findOne method.
Now users would be able to make more requests to Datastore using one Transaction.

Closes #260

@coveralls
Copy link

coveralls commented Nov 22, 2021

Coverage Status

Coverage remained the same at 98.335% when pulling 55b1b39 on dmk1111:feat/add-transaction-find-one into 6492528 on sebelga:master.

@carnun
Copy link
Collaborator

carnun commented Dec 13, 2021

@dmk1111 if you can please add a unit test to https://github.com/sebelga/gstore-node/blob/master/__tests__/integration/model.ts then we can look at getting this into the library as soon as possible.

@dmk1111
Copy link
Contributor Author

dmk1111 commented Jul 26, 2022

@carnun added. Sorry it took so much time :(

@dmk1111 dmk1111 force-pushed the feat/add-transaction-find-one branch from 8aa1801 to 55b1b39 Compare July 26, 2022 16:53
@carnun carnun merged commit a8a46b9 into sebelga:master May 17, 2023
@dmk1111 dmk1111 deleted the feat/add-transaction-find-one branch May 22, 2023 18:55
@dmk1111
Copy link
Contributor Author

dmk1111 commented Oct 11, 2023

@carnun could you please tell me if there any timeframe for release with this update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Transaction support to findOne option
3 participants