Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean old folders in install directory #34

Closed
tebjan opened this issue Mar 17, 2022 · 3 comments
Closed

Clean old folders in install directory #34

tebjan opened this issue Mar 17, 2022 · 3 comments
Milestone

Comments

@tebjan
Copy link

tebjan commented Mar 17, 2022

Uninstalling vvvv leaves a folder there, if one is sure that nothing was changed manually in a vvvv install folder, one could press a button to move those directories into the bin.

image

@sebescudie
Copy link
Owner

Hey, yes noticed that as well, I could actually delete this folder when the uninstaller successfully exits, but shouldn't/couldn't it be taken care of by the uninstaller?

@tebjan
Copy link
Author

tebjan commented Mar 23, 2022

This might be the first thought, of course. But the installer is only allowed to remove files that it put there itself. We don't know what a user did or whether some files are changed, so we cannot just delete this folder as it could potentially destroy user work.

so the cleanup has to be an active user decision, which is better placed in the launcher. also, the installer would only be allowed to manage its own specific version, but in this case, one just wants to clean all.

@sebescudie sebescudie added this to the 5.2.1 milestone Nov 3, 2023
@sebescudie
Copy link
Owner

This feature will be part of the next release!

There is a quirk though. It looks like the Launcher has to run in elevated mode to delete files in Program Files, which makes sense.

But apparently, a non-elevated program cannot send messages (like a drag and drop action) to an elevated one. Windows Explorer is usually not elevated, which means that the feature that allows to open a document by dropping it on the Launcher will not work in elevated mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants