Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input field error indicator #14

Closed
ulde01 opened this issue Apr 1, 2019 · 1 comment
Closed

Input field error indicator #14

ulde01 opened this issue Apr 1, 2019 · 1 comment
Labels
🙅‍♂️ Wontfix This will not be worked on

Comments

@ulde01
Copy link

ulde01 commented Apr 1, 2019

(Moved from https://github.sebank.se/DesignLibrary/AngularComponents/issues/56)

Design change 2019-01-30

This change was reviewed in Design Working Group:

  • The error indicator for input fields have a 2 px line (#D81A1A) at the bottom
  • No frame or shadow (as in Bootstrap)
  • No error indication icon in the text field

The reasoning for changing the line from 4 px to 2 px is that the line was too hefty, especially when there were many fields lighting up at the same time. We try this for now and evaluate. Please give us feedback so we can learn in time for the next update.

image

/Ulrika,
Design Management

Discussion: seb-oss/design-library#13

@hjalmers hjalmers added the 🙅‍♂️ Wontfix This will not be worked on label Apr 2, 2019
@hjalmers
Copy link
Contributor

hjalmers commented Apr 2, 2019

see #18 (comment)

@hjalmers hjalmers closed this as completed May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙅‍♂️ Wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants