Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name change: from "Toggle switch" to "Slide toggle" #18

Closed
ulde01 opened this issue Apr 2, 2019 · 2 comments
Closed

Name change: from "Toggle switch" to "Slide toggle" #18

ulde01 opened this issue Apr 2, 2019 · 2 comments
Labels
🙅‍♂️ Wontfix This will not be worked on

Comments

@ulde01
Copy link

ulde01 commented Apr 2, 2019

Design review 2019-03-27

We are changing the name of the Toggle switch to Slide toggle and would like to you update the identifier:

  • Update component-identifier from "component-toggleswitch" to "component-slidetoggle"

Reason
To match convention in other frameworks. It also makes sense to change the identifier.

image

Description: https://designlibrary.sebgroup.com/components/slide-toggle/#usage

@hjalmers
Copy link
Contributor

hjalmers commented Apr 2, 2019

I marked these as won't fix because they will most likely not be part of this library as these kind of changes should be inherited from vanilla and/or bootstrap theme. The focus of this library should be adding logic not som much on styling.

@ulde01
Copy link
Author

ulde01 commented Apr 2, 2019

Great! I leave this completely up to you. I will most likely continue to post issues here so you guys can decide what is relevant.

Only one question, why leave them open?

@hjalmers hjalmers closed this as completed May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙅‍♂️ Wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants