Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: default values for configuration options #92

Closed
devoto13 opened this issue Jul 23, 2015 · 5 comments
Closed

Documentation: default values for configuration options #92

devoto13 opened this issue Jul 23, 2015 · 5 comments

Comments

@devoto13
Copy link

In the documentation configuration options are described, but one thing is missing: default values for each option, which are used, when option is not set.

For example it's not clear, whether any connection pool is used by default and which one? I can open sources and investigate this, but it's much more convenient to have this described in the documentation.

@sebleier
Copy link
Owner

Thanks for the feedback, I'll update the docs tonight.

@devoto13
Copy link
Author

Thank you!

@sebleier
Copy link
Owner

The docs are still a work in progress, so if you see anything wrong, incomplete, or needs rewording, just let me know. I appreciate it!

@devoto13
Copy link
Author

Sure. Besides default values it is clear for me.

One more minor thing, which would be nice to have are "Next" and "Previous" buttons to go to the next and previous pages in the documentation (instead of using back button in browser and clicking on the next topic in menu).

Thank you for a great package BTW 👍

@sebleier
Copy link
Owner

I haven't added the Next and Previous buttons yet, but I've added default information for different configuration options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants