Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename _type modifiers to _state where applicable #589

Closed
sebnitu opened this issue May 23, 2021 · 0 comments · Fixed by #590
Closed

Rename _type modifiers to _state where applicable #589

sebnitu opened this issue May 23, 2021 · 0 comments · Fixed by #590

Comments

@sebnitu
Copy link
Owner

sebnitu commented May 23, 2021

Problem

There are a few components that use the _type_[value] modifier for displaying variants of info, success, caution and danger states. These should be more accurately renamed to _state_[value] modifiers which will better align with how they're used by the input component which already as a _type_[value] modifier. The input's _type_[value] modifier is used for setting an inputs type of form control (matching the attribute equivalent) styles.

@sebnitu sebnitu changed the title Rename _type modifiers to _state Rename _type modifiers to _state where applicable May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant