Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implicit dependency on outdated guzzle/guzzle #1

Closed
stucki opened this issue Jul 10, 2017 · 2 comments
Closed

Remove implicit dependency on outdated guzzle/guzzle #1

stucki opened this issue Jul 10, 2017 · 2 comments

Comments

@stucki
Copy link
Contributor

stucki commented Jul 10, 2017

This project depends on "satooshi/php-coveralls": "^1" which loads guzzle/guzzle. This project is abandoned and results in a warning when running composer update:
Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead.

Unfortunately, the developers at https://github.com/satooshi/php-coveralls/ seem unwilling to add a simple fix for this problem, see php-coveralls/php-coveralls#203.

I propose two solutions to fix the issue, choose what you prefer more:

  • move the dependency to require-dev (because it's only needed for that)
  • alternatively, change the dependency to "satooshi/php-coveralls": "dev-master"

Let me know if I should create a pull request for this.

@seboettg
Copy link
Owner

Hi, thank you for this issue. Feel free to create PR for this.
Thanks!

@stucki
Copy link
Contributor Author

stucki commented Jul 13, 2017

Which of the two approaches do you prefer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants