Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Feature selection states wrong number of best features. #345

Merged
merged 1 commit into from Mar 12, 2023

Conversation

dor132
Copy link
Contributor

@dor132 dor132 commented Mar 11, 2023

What does this implement/fix? Explain your changes
It seems that the grid CV concluded that 5 features provided the best model, but the text after that output stated 3 instead of 5.
Or, Celltype is considered one feature?
In this case, maybe emphasizing this will make things clearer for new learners.

This is a simple one digit change in the docs.

It seems that the grid CV concluded that 5 features provided the best model, but the text after that output stated 3 instead of 5.
@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (942efd3) 97.85% compared to head (2b3a1c9) 97.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          37       37           
  Lines        3270     3270           
  Branches      496      496           
=======================================
  Hits         3200     3200           
  Misses         33       33           
  Partials       37       37           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sebp sebp merged commit 611ed5f into sebp:master Mar 12, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants