Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying domain of StepFunction #375

Merged
merged 1 commit into from
Jun 11, 2023
Merged

Conversation

sebp
Copy link
Owner

@sebp sebp commented Jun 11, 2023

Checklist

What does this implement/fix? Explain your changes
Values outside the interval specified by self.domain will raise an exception. Values in x that are in the interval [self.domain[0]; self.x[0]] get mapped to self.y[0].

By default, the lower bound is set to 0.

Values outside the interval specified by `self.domain`
will raise an exception.
Values in `x` that are in the interval `[self.domain[0]; self.x[0]]`
get mapped to `self.y[0]`.
By default, the lower bound is set to 0.

Fixes #249
@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4021b27) 97.94% compared to head (4a7d6ae) 97.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files          37       37           
  Lines        3354     3361    +7     
  Branches      508      509    +1     
=======================================
+ Hits         3285     3292    +7     
  Misses         33       33           
  Partials       36       36           
Impacted Files Coverage Δ
sksurv/functions.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sebp sebp merged commit c075cf6 into master Jun 11, 2023
29 checks passed
@sebp sebp deleted the step-function-domain branch June 11, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RandomSurvivalForest is not consistent making predictions of survival functions at certain times
1 participant