Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Cast to correct dtype if X has missing values #412

Merged
merged 1 commit into from Oct 8, 2023
Merged

Conversation

sebp
Copy link
Owner

@sebp sebp commented Oct 8, 2023

Checklist

  • pytest passes
  • tests are included
  • code is well formatted
  • documentation renders correctly

What does this implement/fix? Explain your changes
Fix error in SurvivalTree.fit if X has missing values and dtype other than float32

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
sksurv/tree/tree.py 96.34% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@sebp sebp merged commit 88cb6d4 into master Oct 8, 2023
29 checks passed
@sebp sebp deleted the fix-tree-dtype branch October 8, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant