Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overloads for .Write and .Read methods #14

Closed
seclerp opened this issue Feb 6, 2021 · 1 comment
Closed

Add overloads for .Write and .Read methods #14

seclerp opened this issue Feb 6, 2021 · 1 comment
Assignees
@seclerp
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@seclerp
Copy link
Owner

seclerp commented Feb 6, 2021

In some cases, when large data is provided to such methods, these operations could fail because of RAM size limitations.

Should prove such overloads:

void Write(string fileName, Stream sourceStream);
void Read(string fileName, Stream destinationStream);

And also such overloads should use buffering instead of writing all data at once.
@seclerp seclerp added the enhancement New feature or request label Feb 6, 2021
@seclerp seclerp self-assigned this Feb 6, 2021
@seclerp seclerp added this to the Initial milestone Feb 6, 2021
seclerp added a commit that referenced this issue Feb 7, 2021
@seclerp
#14: Add buffered overloads for .Write and .Read methods, refactor Ex…
457702f 
…port and Import to be buffered
@seclerp
Copy link
Owner Author

seclerp commented Feb 7, 2021

Done

@seclerp seclerp closed this as completed Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seclerp seclerp

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@seclerp