Installer not working

[tpmccallum]

Hi
When attempting to update wasmedge-extensions to the latest version the following issue is occurring.

Line 377 of install.sh [1] is trying to download the following URL which does not exist.

https://github.com/second-state/WasmEdge-tensorflow/releases/download/0.9.0~rc.1/WasmEdge-tensorflow-0.9.0~rc.1-manylinux2014_x86_64.tar.gz

[1] https://github.com/WasmEdge/WasmEdge/blob/master/utils/install.sh#L377

[tpmccallum]

This is caused by an issue with tilde ~ vs dash -

For example, the following release (where I replace the ~ with -) does exist.

https://github.com/second-state/WasmEdge-tensorflow/releases/download/0.9.0-rc.1/WasmEdge-tensorflow-0.9.0-rc.1-manylinux2014_x86_64.tar.gz

[tpmccallum]

We can update the WasmEdge-tensorflow release URL to contain a ~ so the install.sh can remain the same and still work.

You will notice that the pre-install.sh script [1] in the wasmedge-extensions/scripts directory actually uses a static version of the install.sh which does this conversion where the - is replaced with ~

[1] https://github.com/second-state/wasmedge-extensions/blob/master/scripts/preinstall.sh#L8

[tpmccallum]

Whilst the 0.9.0 rc 1 is officially a pre-release in GitHub, the install.sh scripts code still considers it the latest release.

For example, this code

git ls-remote --refs --tags "https://github.com/second-state/WasmEdge-tensorflow.git" | cut -d '/' -f 3 | tr '-' '~' | sort --version-sort | tail -1 

Returns this result

0.9.0~rc.1

[tpmccallum]

You will notice that the pre-install.sh script [1] in the wasmedge-extensions/scripts directory actually uses a static version of the install.sh which does this conversion where the - is replaced with ~

I see that the master branch has removed the conversion so in the long term if we create another build of the static script and then make sure that the preinstall.sh links to the new one we will not have this issue in the future.

[1] https://github.com/second-state/wasmedge-extensions/blob/master/scripts/preinstall.sh#L8

[hydai]

Yup. Maybe using the latest master instead of the static commit version will be a better way to fix this.

[tpmccallum]

I updated the preinstall.sh to use the master/main branch and that particular error has been resolved.

There is a new issue, as per below

https://github.com/WasmEdge/WasmEdge/releases/download//WasmEdge--manylinux2014_x86_64.tar.gz

You can see how the // and -- indicate that the $VERSION is not being set and transferred into the URL.

I have created a PR which resolves this
https://github.com/WasmEdge/WasmEdge/pull/511/files

[hydai]

I will revert and force pushed the master branch. And we will never do any modification on master directly. Please send a PR to make sure the CI are passing and then merge it.

[hydai]

Also, we have a working PR #4 to fix this issue.