[BUG-233311] [PBR] This is pre-existing bug got worse...

[sl-service-account]

What just happened?

Sunsets are abhorrent in PBR, and they were already awful and seem to have remained unfixed since EEP - despite bug reports to the contrary.

Current-ish FS: (my local dev branch but effectively 6.6.8. https://i.gyazo.com/a118fd96d796de238c14dccb04513f6f.jpg
WiP FS PBR build : https://i.gyazo.com/36e08e283dc127b24292bb541eec9deb.jpg
SL PBR Viewer: https://i.gyazo.com/8610b4ff5d7e3cc8997cbfc3e2de0875.jpg

What were you doing when it happened?

Following up a report of this issue.
Users (phtographers/sailors/etc - basically those inclined to watching sunsets/moonrises) are complaining because, under the three version rule that FS follows, we are about to block the last known working version.

These shots were all taken at Serendipitous sands. They all use the 'Barcelona' sky preset and the 'Mirror water' water preset.
sit on the swing, the camera adjusts. Set the azimuth and elevation in personal lighting to the values shown

What were you expecting to happen instead?

The reflection should, just maybe, look like it is at least trying to be a reflection :-)

The current white blob not only seems to ignore the sky but seems to have no transform for the water plane at all.

Other information

I am raising this as a PBR bug because, even though it exists prior to this, we can hardly hold our heads up and claim PBR is a thing when we can't get sun/sky reflections on water right. Also because there seems little point in fixing this in another branch given that it would need to be fixed again here no doubt.

Attachments

• WaterReflections.png 2023-02-03 08:43:10
• WaterReflection With Colors.png 2023-02-03 08:46:13

Links

Related

• [BUG-229013] [EEP] Moonset inconsistent #6965
• [BUG-232817] Colours of reflections are wrong at Sunrise and sunset #10014

Original Jira Fields

Field	Value
Issue	BUG-233311
Summary	[PBR] This is pre-existing bug got worse...
Type	Bug
Priority	Unset
Status	Closed
Resolution	Triaged
Reporter	Beq Janus (beq.janus)
Created at	2023-02-02T15:16:51Z
Updated at	2023-11-28T19:24:02Z

{
  'Build Id': 'unset',
  'Business Unit': ['Platform'],
  'Date of First Response': '2023-02-02T12:30:47.553-0600',
  "Is there anything you'd like to add?": "I am raising this as a PBR bug because, even though it exists prior to this, we can hardly hold our heads up and claim PBR is a thing when we can't get sun/sky reflections on water right. Also because there seems little point in fixing this in another branch given that it would need to be fixed again here no doubt. ",
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': 'Sunsets are abhorrent in PBR, and they were already awful and seem to have remained unfixed since EEP - despite bug reports to the contrary. \r\n\r\nCurrent-ish FS: (my local dev branch but effectively 6.6.8. https://i.gyazo.com/a118fd96d796de238c14dccb04513f6f.jpg\r\nWiP FS PBR build : https://i.gyazo.com/36e08e283dc127b24292bb541eec9deb.jpg\r\nSL PBR Viewer: https://i.gyazo.com/8610b4ff5d7e3cc8997cbfc3e2de0875.jpg',
  'What were you doing when it happened?': "Following up a report of this issue. \r\nUsers (phtographers/sailors/etc - basically those inclined to watching sunsets/moonrises) are complaining because, under the three version rule that FS follows, we are about to block the last known working version. \r\n\r\nThese shots were all taken at Serendipitous sands. They all use the 'Barcelona' sky preset and the 'Mirror water' water preset.\r\nsit on the swing, the camera adjusts. Set the azimuth and elevation in personal lighting to  the values shown",
  'What were you expecting to happen instead?': 'The reflection should, just maybe, look like it is at least trying to be a reflection :-)\r\n\r\nThe current white blob not only seems to ignore the sky but seems to have no transform for the water plane at all.',
  'Where': 'http://maps.secondlife.com/secondlife/Au%20Paradis/142/16/21\r\n\r\n',
}

[sl-service-account]

Dan Linden commented at 2023-02-02T18:30:48Z

Thank you for your report, Beq!

I want to clarify the issues that you are reporting here.

1. The color of the reflection is not matching the sun color, like BUG-232817.
2. The reflection is ignoring the bumpiness of the water.

Is that correct?

[sl-service-account]

JIRAUSER344219 commented at 2023-02-03T13:44:25Z

This is still not working and will go away completely when FS blocks the last working version.  This is from the Secondlife Viewer ....same as with Firestorms latest versions.  

[sl-service-account]

JIRAUSER344219 commented at 2023-02-03T13:46:25Z

This is what it looks like using the FS version that is getting blocked in a few days.   

[sl-service-account]

Beq Janus commented at 2023-02-07T00:09:01Z

@dan

Sorry, it took me a little while to properly understand what I was trying to say :)

I think you are probably right that this is a duplicate of BUG-232817, apologies, I found the previous one that was marked as resolved but had not found this. However, it may be worth clarifying that this is not a problem with the sun colour not reflecting, nor with the cloud colour not reflecting; that is the appearance of the issue, but, if you examine the EEP settings, there is no tint to the sun, or clouds, what the water is reflecting is the "correct" outright colour of the sun, but in the working viewers the sunset colour is being generated by the atmospheric scattering and independent of the colouration of the sun itself. It was, therefore, presumably broken by a shader change to the water (there was a lot of work to fix the badly broken water performance, as you'll recall) in the perf updates.

This is most easily demonstrated with a quick video. This video was shot at http://maps.secondlife.com/secondlife/Whimberly/91/169/27

I am facing west, I have created a local copy of "coastal sunset" and I am editing it. 

First, we can see that there is no tint, but as I change the elevation, the atmospherics are applied and affect the colouration in the sky, but not in the water. 

Next, we deliberately tint the sun (and the clouds if we so choose) and those are reflected. 

Conclusion: the water shader does not appear to apply any atmospheric scattering effects and thus does not reflect/follow the hue changes of the sky at sunset and sunrise.

https://gyazo.com/52496ba84695f87ae393ebf5cf4efab5

 

The second claim I made as not that the normals are not being applied but that the sun disc reflection does not seem to be properly transformed thus scale and perspective skew etc. do not seem to be applied by the water shader, or at least not in a natural, physically correct manner. The mirror water shows this with the sun reflection as a bright disk many many times larger then the sun effect itself (This was shown in my original images)

In addition (and this may be related to the overall colouration issue); on looking at this in more detail, I can't be entirely sure what I am seeing. There appears to be some faked highlighting that is present no matter what and that masks some of what is going on.

To see this we need to go to day cycle editing (because for whatever reason we cannot edit a water and a sky together)

load coastal sunset into the ground level sky

load raymond's water into the water

Note that we can change the glow focus and there is some change in the water but it is not correct, glow size likewise. 

You can see in this next clip that while there are some changes to the reflection the bright ripple highlights mask that entirely. 

https://gyazo.com/ed649696a4f33bf6d51a89494f16af7f

 

Hope this helps a bit. 

 

 

[sl-service-account]

Dan Linden commented at 2023-02-07T19:38:44Z

That's very helpful. Thank you, Beq and ARGuy54!