[BUG-40536] Attachment links are sometimes duplicated in COF

[sl-service-account]

• I suspect this bug has the same underlying cause as BUG-37646 - Attachments get ghosted at login on 4.0.7.318301

• I've seen this happen quite a few times on the latest default release, it isn't specific to the VLC-RC, I just happened to be using VLC when I reproduced this occurrence.

• There is no good repro for this - it just happens randomly.

• When you login and check the contents of the Current Outfit folder, often you will see some attachment links are listed twice.

• When you add or remove an attachment, the duplicate links usually get removed from the Current Outfit folder.

  Below are detailed steps of exactly what happened this session it reproduced.

  Steps to Reproduce

• I was logged in on Second Life Release 4.1.1.319766 (VLC test build).

• Session was short and I made no changes to avatar appearance this session, then I logged out.

• Attached secondlife.old log from this session.

• Observe in secondlife.old that during the logout process, some of my attachments "fell off" (unexpected detach in log).

  2016-09-17T17:57:54Z WARNING: LLAttachmentsMgr::onDetachCompleted: ATT unexpected detach for #Firestorm LSL Bridge v2.20 id 9cb2166b-6b88-8589-637f-862c8b416adf
  2016-09-17T17:57:54Z WARNING:#Inventory LLInventoryModel::accountForUpdate: Accounting failed for 'Current Outfit' version:180172 due to mismatched descendent count:  server == 21, viewer == 29
  2016-09-17T17:57:54Z WARNING:#Inventory LLInventoryModel::accountForUpdate: Accounting failed for 'Current Outfit' version:180172 due to mismatched descendent count:  server == 21, viewer == 28
  2016-09-17T17:57:54Z WARNING: LLAttachmentsMgr::onDetachCompleted: ATT unexpected detach for FATEplay - Custom Wings Animator (Required) id c1966cae-2c3f-d4fa-f096-94b91818c037
  2016-09-17T17:57:54Z WARNING:#Inventory LLInventoryModel::accountForUpdate: Accounting failed for 'Current Outfit' version:180172 due to mismatched descendent count:  server == 21, viewer == 27
  2016-09-17T17:57:54Z WARNING: LLAttachmentsMgr::onDetachCompleted: ATT unexpected detach for Violent Seduction - Lilith Boots (Black) id c29ccd16-c473-b0d2-dfdc-6bcb5cd9d17b
  2016-09-17T17:57:54Z WARNING:#Inventory LLInventoryModel::accountForUpdate: Accounting failed for 'Current Outfit' version:180172 due to mismatched descendent count:  server == 21, viewer == 26
  2016-09-17T17:57:54Z WARNING:#Inventory LLInventoryModel::accountForUpdate: Accounting failed for 'Current Outfit' version:180172 due to mismatched descendent count:  server == 21, viewer == 25
  2016-09-17T17:57:54Z WARNING: LLAttachmentsMgr::onDetachCompleted: ATT unexpected detach for Violent Seduction - Lilith Gloves (Black) id 8cfdb471-5eae-d852-166f-e73a4b48bf67
  2016-09-17T17:57:54Z WARNING:#Inventory LLInventoryModel::accountForUpdate: Accounting failed for 'Current Outfit' version:180172 due to mismatched descendent count:  server == 21, viewer == 24
  2016-09-17T17:57:54Z WARNING:#Inventory LLInventoryModel::accountForUpdate: Accounting failed for 'Current Outfit' version:180172 due to mismatched descendent count:  server == 21, viewer == 23
  2016-09-17T17:57:54Z WARNING: LLAttachmentsMgr::onDetachCompleted: ATT unexpected detach for [whatever] Eyes - #10 - right id 5843fe5e-9daa-3bd4-f1a5-350ac5c21c5d
  2016-09-17T17:57:54Z WARNING:#Inventory LLInventoryModel::accountForUpdate: Accounting failed for 'Current Outfit' version:180172 due to mismatched descendent count:  server == 21, viewer == 22
  2016-09-17T17:57:54Z WARNING: LLAttachmentsMgr::onDetachCompleted: ATT unexpected detach for [whatever] Eyes - #10 - left id d363276e-d83a-7061-569c-f1c5c2be6b9f
  2016-09-17T17:57:54Z WARNING: LLAttachmentsMgr::onDetachCompleted: ATT unexpected detach for [AK] BENTO Lola Mesh Head Preview! id c0dc7af3-0e1d-6c91-8dd3-260ce992a386

• The attachments that logged an "unexpected detach" were:

  • #Firestorm LSL Bridge v2.20
  • FATEplay - Custom Wings Animator (Required)
  • Violent Seduction - Lilith Boots (Black)
  • Violent Seduction - Lilith Gloves (Black)
  • [whatever] Eyes - [BUG-10010] Test #10 - right
  • [whatever] Eyes - [BUG-10010] Test #10 - left
  • [AK] BENTO Lola Mesh Head Preview!

• So question - is this "normal" for attachments to be unexpectedly detached during logout?
  I see this happen a lot since the Shining fixes & the BigBird changes - so since AIS3 I guess?
  This same unexpected attachment detach happens often on teleport too, but since the BigBird changes, usually most attachments that "fell off" get reattached shortly after the teleport has completed (you can visibly see them missing and then reattached, both on your avatar and in COF), though I feel this is related to the ghosted attachments on teleport problem that still reproduces, where the viewer thinks an object is attached but the region thinks it's detached and vice versa.
  So maybe the ghosted attachments at login (BUG-37646) is really the same problem as the ghosted attachments after a region change?

• I then installed the current VLC-RC viewer Second Life 4.1.1.319583 (Second Life Release) and logged in on it (same avatar as previous session).

• I couldn't see my mesh head attachment on my avatar, so I opened Current Outfit folder to see if it was attached.
  It was, but then I noticed I'd reproduced this duplicate attachment links bug again.
  Note that it was actually expected that I couldn't see the mesh head in this case - it's a Bento head and I was on a non-Bento viewer (derp!).

• Fig 1 attached shows the contents of my COF folder after login, before any changes were made to avatar appearance.

• The following attachments have duplicated links in COF

  • Violent Seduction - Lilith Boots (Black)
  • FATEplay - Custom Wings Animator (Required)
  • #Firestorm LSL Bridge v2.20
  • Violent Seduction - Lilith Gloves (Black)
  • [whatever] Eyes - [BUG-10010] Test #10 - left
  • [whatever] Eyes - [BUG-10010] Test #10 - right
  • [AK] BENTO Lola Mesh Head Preview!
  • little bones. Reckless (L)
  • Violent Seduction - Lilith Dress (Black) RARE

• The following attachments do not have duplicated links in COF

  • FATEplay - Custom Wings (always on)
  • Maitreya Mesh Body - Lara V3.5
  • (HUD AO)SLC AO Stimulus [ZHAO-II MB2.0.17mod]
  • Maitreya Mesh Body - HUD V3.5 Lara

• So far I have only ever seen attachment links duplicated, never skin, shape, hair, eyes or clothing layers.
  Unsure if this is just coincidence or whether this does only affect attachments.

• From the COF folder I then right clicked -> Detach from yourself on the [AK] BENTO Lola Mesh Head Preview!

• The head was removed from COF and all the other duplicated COF links were also removed, so my COF was then showing the correct state of what I was actually wearing.

• Fig 2 attached shows the contents of COF after removing the mesh head.

• Secondlife.log attached is from the session where I reproduced the duplicated COF links.

  Observed Behaviour

  Sometimes after logging in, attachments links are duplicated in the Current Outfit folder.

  Expected Behaviour

  Each worn attachment should only have a single link in COF.

Attachments

• Fig 1.png 2016-09-17 14:37:28
• Fig 2.png 2016-09-17 15:08:38
• SecondLife.log 2016-09-17 15:12:55
• SecondLife.old 2016-09-17 14:37:57

Links

Related

• [BUG-37646] Attachments get ghosted at login on 4.0.7.318301 #11984
• [BUG-11929] Appearance update is STILL broken after recent changes in 4.0.4 (314579) #2039
• [BUG-10391] [Project Azumarill] Avatar often bakes fails on Azumarill #723

Original Jira Fields

Field	Value
Issue	BUG-40536
Summary	Attachment links are sometimes duplicated in COF
Type	Bug
Priority	Unset
Status	Been Triaged
Resolution	Triaged
Reporter	Whirly Fizzle (whirly.fizzle)
Created at	2016-09-17T18:15:20Z
Updated at	2016-09-26T17:11:17Z

{
  'Business Unit': ['Platform'],
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': 'Filling in...',
  'What were you doing when it happened?': '....',
  'What were you expecting to happen instead?': '....',
}