[BUG-226772] [EEP] Full bright objects are not affected by fog

[sl-service-account]

This is a duplicate of BUG-4882, which has never been fixed in the LL viewer.
With the way that EEP environments are overly fogged when ALM is enabled though, the bug is even more apparent & I feel it's important to finally fix this bug.
This bug is a real pest for photographers who want to take images of a foggy scene that includes full bright objects.
Most TPV's already have this bug fixed - see "Other Information"

Steps To Reproduce

• Apply any foggy environment, for example "[TOR] FOGGY - Das fog" from the library.

• Rez out some full bright objects & observe how the full bright objects look as you cam away from them.

• Nice test location is http://maps.secondlife.com/secondlife/Ministry%20of%20Invention/182/65/119 which has lots of full bright vendors.
  Alternatively http://maps.secondlife.com/secondlife/Satanic%20Visions/249/125/1501

  Observed Behaviour

• Fig 1 attached shows the scene on the EEP viewer at http://maps.secondlife.com/secondlife/Ministry%20of%20Invention/182/65/119 using environment setting "[TOR] FOGGY - Das fog"
  You can see that the full bright vendors are not affected by the fog.

• Fig 2 attached shows legacy Firestorm using a modified "[TOR] FOGGY - Das fog" to make it as foggy as that setting is on EEP.
  This version of Firestorm has the full bright + fog bug fixed
  Ignore the fact their is no light from the skylights, that's just the way I edited that legacy windlight.

  Expected Behaviour

  Full bright objects should be affected by fog.

  Other Information

• The fix legacy Firestorm & other TPVs have for this bug is from Sovereign Engineer (Alchemy Viewer).
  https://hg.phoenixviewer.com/phoenix-firestorm-lgpl/rev/c8f7ce33473c

• I have no idea if this fix is compatible with EEP but after the EEP merge this fix broke on Firestorm too.

• Also see the forum posts starting here: https://community.secondlife.com/forums/topic/428374-environmental-enhancement-project-aka-eep-feedback-thread/?do=findComment&comment=1878898

Attachments

• Fig 1 - EEP.png 2019-04-15 14:00:09
• Fig 2 - Firestorm with fix.png 2019-04-15 14:08:42

Links

Related

• [BUG-226767] [EEP] Any environment with fog looks terrible #5223

Original Jira Fields

Field	Value
Issue	BUG-226772
Summary	[EEP] Full bright objects are not affected by fog
Type	Bug
Priority	Unset
Status	Accepted
Resolution	Accepted
Labels	whirly-eep
Reporter	Whirly Fizzle (whirly.fizzle)
Created at	2019-04-15T17:49:00Z
Updated at	2020-06-15T15:23:05Z

{
  'Build Id': 'unset',
  'Business Unit': ['Platform'],
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': 'Filling in...',
  'What were you doing when it happened?': '...',
  'What were you expecting to happen instead?': '....',
  'Where': 'Any region',
}