[BUG-229108] Bug in class LLToolsSelectNextPartFace (in llviewermenu.cpp)

[sl-service-account]

What just happened?

If you have the build/edit floater shown with edit linked and faces mode active and click on a face the object's name/description will be populated in the floater. However, if you cycle through faces using CTRL-comma or CTRL-fullstop it won't be.

The fix is to use LLSelectMgr::getInstance() - > selectObjectOnly(to_select, new_te); instead of LLSelectMgr::getInstance() -> addAsIndividual(to_select, new_te, FALSE); which mimics the behaviour of the click on a face more accurately

[Minor edit to remove unintended strokethrough markup)

What were you doing when it happened?

What were you expecting to happen instead?

Object name/description should be populated however the face was selected

Other information

Links

Related

• [BUG-232757] Include next/previous face doesn't work  #9969

Original Jira Fields

Field	Value
Issue	BUG-229108
Summary	Bug in class LLToolsSelectNextPartFace (in llviewermenu.cpp)
Type	Bug
Priority	Unset
Status	Closed
Resolution	Triaged
Reporter	Chorazin Allen (chorazin.allen)
Created at	2020-07-20T14:37:08Z
Updated at	2022-10-11T17:20:03Z

{
  'Build Id': 'unset',
  'Business Unit': ['Platform'],
  'ReOpened Count': 0.0,
  'Severity': 'Unset',
  'System': 'SL Viewer',
  'Target Viewer Version': 'viewer-development',
  'What just happened?': "If you have the build/edit floater shown with edit linked and faces mode active and click on a face the object's name/description will be populated in the floater. However, if you cycle through faces using CTRL-comma or CTRL-fullstop it won't be.\r\n\r\nThe fix is to use LLSelectMgr::getInstance()->selectObjectOnly(to_select, new_te); instead of LLSelectMgr::getInstance()->addAsIndividual(to_select, new_te, FALSE); which mimics the behaviour of the click on a face more accurately",
  'What were you doing when it happened?': '-',
  'What were you expecting to happen instead?': 'Object name/description should be populated however the face was selected',
  'Where': 'N/A',
}